Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: disallow printing void #17901

Merged
merged 2 commits into from Apr 7, 2023
Merged

checker: disallow printing void #17901

merged 2 commits into from Apr 7, 2023

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Apr 6, 2023

Fixes #17900

@JalonSolov
Copy link
Contributor

Seems like it would be a good idea to not allow printing any call that doesn't return anything.

@medvednikov
Copy link
Member

Indeed, but this seems to be a generic fix. The name of the commit should be "disallow printing void"

@JalonSolov
Copy link
Contributor

Ah, you're right. I looked at the title and the commit message, but not the code. After looking at the code, I agree.

@Delta456 Delta456 changed the title checker: disallow printing of array.delete checker: disallow printing void Apr 7, 2023
@Delta456
Copy link
Member Author

Delta456 commented Apr 7, 2023

Yeah, you are correct. Fixed the title.

@medvednikov medvednikov merged commit 65abfa8 into vlang:master Apr 7, 2023
49 checks passed
@Delta456 Delta456 deleted the array_delete_print_err branch April 7, 2023 04:57
l1mey112 pushed a commit to l1mey112/v that referenced this pull request Jun 7, 2023
@Delta456 @l1mey112
checker: disallow printing void (vlang#17901)
3a9e2ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c-gen bug when printing an array.delete
3 participants
@Delta456 @JalonSolov @medvednikov