Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: fix alias type stripped comments #18346

Merged
merged 1 commit into from Jun 4, 2023

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Jun 4, 2023

Fix #18343

馃 Generated by Copilot at 7c772ce

This pull request improves the handling of comments in type declarations, both in the parser and the formatter. It fixes a bug that dropped comments after sum type variants in vlib/v/parser/parser.v and adds some tests for the type declaration formatting with comments in vlib/v/fmt/tests/type_decl_comments_keep.vv.

馃 Generated by Copilot at 7c772ce

  • Fix a bug in the parser that caused comments after sum type variants to be lost (link)
  • Add test cases for type declaration formatting with comments in vlib/v/fmt/tests/type_decl_comments_keep.vv (link)

@felipensp felipensp marked this pull request as ready for review June 4, 2023 18:49
@medvednikov medvednikov merged commit 5440657 into vlang:master Jun 4, 2023
50 checks passed
l1mey112 pushed a commit to l1mey112/v that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] vfmt eats the trailing comment after pub type
2 participants