Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: disallow assigning mutable reference to immutable ParExpr #18420

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Jun 12, 2023

fixes #18414

🤖 Generated by Copilot at 366f838

This pull request improves the parsing, formatting, and checking of prefix operators and reference assignments in V. It removes unnecessary parenthesis, fixes a checker bug, and deletes a redundant test file.

🤖 Generated by Copilot at 366f838

  • Fix checker bug for assigning mutable references in parenthesis expressions (link)
  • Move special case handling of ! prefix operator from formatter to parser (link)
  • Remove redundant case handling of & prefix operator from formatter (link)
  • Delete test file module_ref_type_keep.vv that is no longer relevant (link)

@ttytm ttytm changed the title fix: unallowed mutable reference assignment checker: disallow assigning mutable reference to immutable ParExpr Jun 12, 2023
@ttytm ttytm marked this pull request as ready for review June 12, 2023 17:41
@medvednikov medvednikov merged commit 2ca3046 into vlang:master Jun 13, 2023
49 checks passed
@ttytm ttytm deleted the checker/mut-assign branch August 22, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fmt removes parentheses when it shouldn't
2 participants