Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix msvc packed attr #18437

Merged
merged 2 commits into from Jun 14, 2023
Merged

cgen: fix msvc packed attr #18437

merged 2 commits into from Jun 14, 2023

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Jun 13, 2023 •
edited by ghost

Fix #18435

馃 Generated by Copilot at 9356dd5

Fix MSVC compilation error for enums with __attribute__((packed)). Skip this attribute for MSVC in vlib/v/gen/c/cgen.v.

馃 Generated by Copilot at 9356dd5

  • Fix MSVC compatibility issues for V by applying conditional compilation and using alternative syntax for some features (link, F0L

@crackedmind
Copy link
Member

This fix only enums, what about structs?

@felipensp
Copy link
Member Author

This fix only enums, what about structs?

Yes, I've added the struct part.

@felipensp felipensp marked this pull request as ready for review June 13, 2023 15:07
@medvednikov medvednikov merged commit 23da212 into vlang:master Jun 14, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delta456 Delta456 Delta456 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[packed] attribute must not add __attribute__((__packed__)) for msvc compiler
4 participants
@felipensp @crackedmind @Delta456 @medvednikov