strconv.atoi: bug fix #18875 #18925
Merged
strconv.atoi: bug fix #18875 #18925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Jul 21, 2023
| } | ||
|
|
||
| // check for digit over base | ||
| if c >= base { | ||
| if c > basem1 || (sub_count == 0 && c > 9) { |
There was a problem hiding this comment.
What is 9 here? Should it not be related to _base somehow?
There was a problem hiding this comment.
yes, basem1 stands for base - 1 that is calculated outside the loop, it is a simple optimization.
make operation inside an if is always expensive as cpu cycles.
basem1 will be stored in a register that will speed up the check in the loop.
The 9 is due the fact that if the flow arrive at that line with sub_count equal to 0 and the value is greater then 9, it is an illegal char in the sequence.
Are all optimizations in order to try to squeeze cpu cycle in the conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is inside
common_parse_uint2