Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: add check for chan type is empty (fix #19162) #19167

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Aug 17, 2023

Closes #19162

馃 Generated by Copilot at 78652d1

This pull request improves the error handling of the parser for chan declarations. It adds a new error message, a test case, and an expected output file for chan declarations with no type specified.

馃 Generated by Copilot at 78652d1

  • Add error message for chan declarations with no type (link)
  • Add test case for the error message (link, link)
    • Create a source code file no_chan_type_provided_err.vv that declares a chan with no type (link)
    • Create an expected output file no_chan_type_provided_err.out that contains the error message and the source code location (link)

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman changed the title parser: add check for chan type is empty parser: add check for chan type is empty (fix #19162) Aug 17, 2023
@spytheman spytheman merged commit c862394 into vlang:master Aug 17, 2023
49 checks passed
@Delta456 Delta456 deleted the parser_check_chan_type branch August 17, 2023 20:19
Wertzui123 pushed a commit to Wertzui123/v that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiler panic for _ := chan{}
2 participants