New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
math: fix failing test on FreeBSD with gcc 12.2.0 (and -ffast-math) #19278
Merged
spytheman
merged 17 commits into
vlang:master
from
spytheman:math_fix_gcc_failure_on_freebsd
Sep 6, 2023
Merged
math: fix failing test on FreeBSD with gcc 12.2.0 (and -ffast-math) #19278
spytheman
merged 17 commits into
vlang:master
from
spytheman:math_fix_gcc_failure_on_freebsd
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the ci job (it is done by a separate vps for ~ 1 year now)
…12 -cflags -fsanitize=undefined vlib/math/math_test.v`
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both invocations below pass now on FreeBSD 13.0-RELEASE-p13:
v -fast-math -cc gcc vlib/math/math_test.v
and
v -cc gcc vlib/math/math_test.v
🤖 Generated by Copilot at 6d1f811
This pull request enhances the
vlib/math
module by improving the test coverage and reliability, fixing the floating-point comparison and NaN detection, and adding some debugging prints. These changes are mainly related to the-fast-math
flag and its effects on the math functions.🤖 Generated by Copilot at 6d1f811
is_nan
to handle quiet NaNs with fast math (link)math_test.v
that may fail with fast math due to different behavior ofacos
,atan2
,sign
, andexp
functions (link, link, link, link)test_round
that was skipping assertions involving zero (link)alike
function inmath.v
to use a more robust comparison of floating-point numbers, ignoring the last two bits of the binary representation (link)round
andalike
for debugging purposes, which should be removed before merging (link, link)