-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly include utime.h and set defines for FreeBSD #19285
Conversation
Given that this is a FreeBSD specific change, I find it curious that the FreeBSD Code CI task is skipped. |
The FreeBSD CI is triggered only for commits that do changes to .v files and to .cirrus.yml, since most of the thirdparty/ dependencies so far, were from more or less already portable libs (and we change thirdparty/ very seldom). It can be turned on by editing Note that will not be enough, since it does only a limited run of the tests there, since there are more known failing cases, i.e. instead of What we can do, is add another step there though, that just does: Edit: added in 491fce7 . |
The CI passed in https://cirrus-ci.com/task/5813841334894592 , after the task name was changed to use a |
* master: (128 commits) ci: update containers_ci.yml to not try to install libexecinfo-static, which is not present on the latest Alpine image checker: disallow module name duplicates in local names (vlang#18118) cgen: cleanup go_before_stmt(0) (vlang#19308) parser: disallow using `sql` as name (vlang#19298) fmt: cleanup fmt comments (vlang#19306) tests: supplement test cases in fixed_array_const_size_test.v (vlang#19303) vdoc: prevent main-content outline with certain devices / browsers (vlang#19304) cgen: fix printing struct with thread field (vlang#19302) vlib: replace macros that resolve to __builtin_bswapnn calls for tcc (vlang#19305) time: add `MMM` in the doc comment for parse_format() (vlang#19299) os: include sys/sysctl.h on FreeBSD to avoid implicit definition of sysctl function (vlang#19293) parser, transformer: fix transformer.infix_expr() and cleanup parse_types.v (related vlang#19269) (vlang#19276) fmt: simplify the processing logic for removing inline comments (vlang#19297) db.pg: allow postgres connection using service definitions (vlang#19288) builtin: use `libgc-threaded` on FreeBSD, to get the threaded version of libgc (vlang#19294) ci: test the pure V math versions without .c.v overrides on the CI too (vlang#19292) all: support `./v -exclude @vlib/math/*.c.v vlib/math/math_test.v`, for using the pure V math module implementation, without the .c.v overrides there. (vlang#19290) .cirrus.yml: change test_zip_modules -> test_zip_modules_script, so that the CI can recognise the new task name and execute it thirdparty/zip: properly include utime.h and set defines for FreeBSD (vlang#19285) math: fix pure v math.pow (vlang#19287) ...
thirdparty/zip: when compiling on FreeBSD, include <utime.h> and set defines for various file operations.
🤖 Generated by Copilot at 025a246
Add FreeBSD file I/O support to
miniz.h
library. This enables vlang/v to use zip compression and decompression on FreeBSD platform.🤖 Generated by Copilot at 025a246