toml: check if supported type was passed for decoding when it has no method #19317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
changed the title
spytheman
reviewed
Sep 10, 2023
spytheman
approved these changes
Sep 10, 2023
Wertzui123
pushed a commit
to Wertzui123/v
that referenced
this pull request
Oct 8, 2023
…toml.decode`, when the type has no custom `.from_toml` method defined (vlang#19317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 5931238
This pull request improves the error handling of the
toml.decodefunction by adding a compile-time check for the generic type parameter and a test case for it. It ensures that the function only accepts structs as the type parameter and returns a clear error message otherwise.🤖 Generated by Copilot at 5931238
toml.decodefunction (link)toml.decodefunction with non-struct types (link)toml.decodefunction returns an error with the expected type name for non-struct types (link)