Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: simplify formatting assign statement comments #19524

Merged
merged 2 commits into from Oct 8, 2023
Merged

fmt: simplify formatting assign statement comments #19524

merged 2 commits into from Oct 8, 2023

Conversation

yuyi98
Copy link
Member

@yuyi98 yuyi98 commented Oct 7, 2023

This PR simplify formatting assign statement comments.

@medvednikov medvednikov merged commit 05d940a into vlang:master Oct 8, 2023
42 checks passed
@JalonSolov
Copy link
Contributor

Perhaps v fmt should give a warning that an inline comment was removed? At least for a while. Otherwise, it is silently lost data, which is bad.

@yuyi98 yuyi98 deleted the simplify_fmt_assign_stmt_comments branch October 8, 2023 12:05
Wertzui123 pushed a commit to Wertzui123/v that referenced this pull request Oct 8, 2023
@yuyi98 @Wertzui123
fmt: simplify formatting assign statement comments (vlang#19524)
d365b8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Larpon Larpon Larpon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuyi98 @JalonSolov @Larpon @medvednikov