Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sokol: fix usage of sokol sampler #19527

Merged
merged 1 commit into from Oct 7, 2023
Merged

sokol: fix usage of sokol sampler #19527

merged 1 commit into from Oct 7, 2023

Conversation

Larpon
Copy link
Contributor

@Larpon Larpon commented Oct 7, 2023

No description provided.

@Larpon Larpon mentioned this pull request Oct 7, 2023
Closed
spytheman
spytheman approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Thank you. I could not figure out how to fix the shader compilation error for over 2 days.

@medvednikov
Copy link
Member

Thanks! I'll update ui right now.

@JalonSolov
Copy link
Contributor

JalonSolov commented Oct 7, 2023 •
edited by Larpon

Hmm...

src/extra_draw.v:374:7: error: expected 2 arguments, but got 1
  372 |         sgl.load_pipeline(ctx.pipeline.alpha)
  373 |         sgl.enable_texture()
  374 |         sgl.texture(simg)
      |             ~~~~~~~~~~~~~
  375 |         sgl.begin_quads()
  376 |         sgl.c4b(255, 255, 255, 255)

@medvednikov medvednikov merged commit 3c68e78 into vlang:master Oct 7, 2023
27 of 30 checks passed
@Larpon
Copy link
Contributor Author

Larpon commented Oct 7, 2023

Hmm...

src/extra_draw.v:374:7: error: expected 2 arguments, but got 1
  372 |         sgl.load_pipeline(ctx.pipeline.alpha)
  373 |         sgl.enable_texture()
  374 |         sgl.texture(simg)
      |             ~~~~~~~~~~~~~
  375 |         sgl.begin_quads()
  376 |         sgl.c4b(255, 255, 255, 255)

Ouch I might have overlooked that 😳

@Larpon Larpon deleted the gfx/fix-sokol-sampler-change branch October 7, 2023 20:40
@medvednikov
Copy link
Member

Already fixed.

Wertzui123 pushed a commit to Wertzui123/v that referenced this pull request Oct 8, 2023
@Larpon @Wertzui123
sokol: fix usage of sokol sampler (vlang#19527)
2a4e547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Larpon @medvednikov @JalonSolov @spytheman