checker: warn about byte deprecation when used as fn param #19629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
approved these changes
Oct 23, 2023
ttytm
force-pushed
the
checker/byte-dep-param-warn
branch
from
841f403
to
3753bee
Compare
ttytm
commented
Oct 23, 2023
Comment on lines
195
to
+198
| // TODO: remove when `byte` is removed | ||
| [markused] | ||
| fn encode_byte(root byte) &C.cJSON { | ||
| return encode_u8(u8(root)) | ||
| fn encode_byte(root u8) &C.cJSON { | ||
| return encode_u8(root) |
There was a problem hiding this comment.
I'm updating this one since usage is the same and without updating it every json test would need to be updated with the current implementation of the warning.
Delta456
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the below won't inform about the byte deprecation
With the changes it will warn, as the next one does:
馃 Generated by Copilot at 841f403
Changed the type of several variables and parameters related to string manipulation from
bytetou8in various modules. Added a warning to the checker module to inform the user thatbyteis deprecated andu8should be used instead. These changes are part of a larger effort to remove thebytealias and useu8consistently throughout the codebase.馃 Generated by Copilot at 841f403
bytewithu8in several places to avoid confusion and improve consistency (link, link, link, link, link)byte, advising the user to useu8instead (link)