Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add macos arm64 binary release #19823

Merged
merged 1 commit into from Nov 9, 2023

Conversation

joe-conigliaro
Copy link
Member

@joe-conigliaro joe-conigliaro commented Nov 9, 2023

馃 Generated by Copilot at 4fa4d23

Added support for Apple Silicon in the V binary release process. Refactored and renamed some GitHub Actions workflows and jobs to use consistent zip file names for different macOS architectures.

馃 Generated by Copilot at 4fa4d23

  • Rename build-macos job to build-macos-x86_64 and introduce ZIPNAME variable to avoid hardcoding zip file names (link)
  • Add build-macos-arm64 job to cross-compile V binary for Apple Silicon architecture and set ZIPNAME to v_macos_arm64.zip (link)
  • Update release job to depend on build-macos-arm64 job and use ZIPNAME variable for upload-artifact action (link)
  • Rename macos job to macos-x86_64 in prebuilt.yml workflow and use v_macos_x86_64.zip file name for wget and unzip commands (link, link)
  • Add comment to explain why macos-arm64 job is not included in prebuilt.yml workflow (link)

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit 78709b0 into vlang:master Nov 9, 2023
24 checks passed
@joe-conigliaro joe-conigliaro deleted the build_macos_arm64 branch November 9, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants