net: use char types that resemble C API of mbedtls more closely #19837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Nov 11, 2023
spytheman
reviewed
Nov 11, 2023
spytheman
reviewed
Nov 11, 2023
spytheman
reviewed
Nov 11, 2023
spytheman
reviewed
Nov 11, 2023
|
The whole file needs to be reviewed and fixed; perhaps it was written before the introduction of the |
|
Thanks a lot for the review @spytheman! You are right all your suggestions should be implemented. It was just the char types that became obvious to me. I'll also go through the whole file later that day to have another pair of eyes on it. |
ttytm
force-pushed
the
net/mbedtls-types
branch
from
78a5e11
to
b04a1df
Compare
|
First of the two new commits does the fixing, the second just organizing. |
ttytm
force-pushed
the
net/mbedtls-types
branch
from
d335f56
to
44e76bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Generated by Copilot at 707357f
Updated the net/mbedtls module to use
&u8instead of&charfor byte parameters. This avoids unnecessary casting and aligns with V's byte type.馃 Generated by Copilot at 707357f
mbedtls_x509_crt_parse,mbedtls_pk_parse_key,mbedtls_net_connect,mbedtls_ssl_read, andmbedtls_ssl_writeto use&u8instead of&charfor byte array parameters (link, link). This improves the compatibility and correctness of the V bindings for the mbedtls C library invlib/net/mbedtls/mbedtls.c.v.