Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix already installed detection when running v install --once without args #19838

Merged

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Nov 10, 2023

🤖 Generated by Copilot at 3990cbf

This pull request improves the vpm tool by adding a --once flag for v install to skip cached modules and by fixing a bug that could miss some modules in the installation process. It affects the files cmd/tools/vpm/dependency_test.v and cmd/tools/vpm/install.v.

🤖 Generated by Copilot at 3990cbf

  • Add --once flag to v install command to skip reinstalling modules that are already in the cache (link, link, link)
  • Test the behavior of --once flag by asserting that no modules are installed and a message is printed when running v install --once again (link)
  • Use num_to_install variable to store the total number of modules to be installed, including dependencies, and compare it with the number of already installed modules in install function in install.v (link, link)

@medvednikov medvednikov merged commit 744b92a into vlang:master Nov 12, 2023
42 checks passed
@ttytm ttytm deleted the tools.vpm/fix-already-install-detection branch November 13, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants