-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgen: fix auto deref for interface variable #19841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
force-pushed
the
fix_auto_deref_iface_var
branch
from
November 14, 2023 09:13
8f953d3
to
ff66734
Compare
spytheman
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
spytheman
approved these changes
Nov 14, 2023
@felipensp can you please also take care of that:
interface Param {}
fn test_main() {
param := Param(false)
match param {
bool {
if param {
dump(param) // switching the dump and the println makes it compile
println(param)
}
}
else {}
}
} |
…sp/v into fix_auto_deref_iface_var
Done. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19834
🤖 Generated by Copilot at 76cc728
Fix bugs in casting interface variables to strings in
cgen.v
,if.v
, andinfix.v
. Add a new field and a helper function to handle interface variable dereferencing in different contexts.🤖 Generated by Copilot at 76cc728
is_interface_var
to simplify checking interface variables (link)inside_casting_to_str
field of theGen
struct (link, link)is_interface_var
function to simplify and fix the condition for writing a*
before the object name in thegen_call_expr
method incgen.v
(link)