Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker: fix generate dump code for array fixed struct field #19886

Merged
merged 2 commits into from Nov 16, 2023

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 15, 2023

Fix #19881

馃 Generated by Copilot at 1c238d6

Enable comptime function return values for fixed arrays by registering their structs in the table. Update vlib/v/checker/comptime.v to handle fixed array type symbols.

馃 Generated by Copilot at 1c238d6

  • Implement comptime function return values by generating and dumping a struct for each comptime function that has a non-void return type (F0

@felipensp felipensp changed the title cgen: fix generate dump code for array fixed struct field checker: fix generate dump code for array fixed struct field Nov 15, 2023
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman
Copy link
Member

@felipensp is it good to be merged?

@felipensp felipensp marked this pull request as ready for review November 15, 2023 19:41
@felipensp
Copy link
Member Author

@felipensp is it good to be merged?

Yes. Thanks.

@spytheman spytheman merged commit ae98080 into vlang:master Nov 16, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cgen failure for an empty $for f in Struct.fields {, when Struct contains fields with a fixed array type
2 participants