Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add output when scanning module in an install query #19934

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Nov 19, 2023

Since more validation logic is moved out of the final install and update process, it can take longer for a user to get an initial feedback from vpm - it's not an instant Installing ... anymore, because the validation is done beforehand. Also, there are cases that don't reach the Installing <moname> print already. This PR adds Scanning <modname> print when parsing and validating the install-query to give a user a quicker feedback that the request is being processed and at what state it is.

For now, I would continue to keep the outputs simple. After most of the teething problems are fixed, I'm planning to propose color-coded outputs for VPM - probably similar cargo, but we can then discuss on Discord which style is appropriate for V.

馃[deprecated] Generated by Copilot at 1dc786e

Improve vpm output by showing scan progress for module identifiers. Add a print statement to cmd/tools/vpm/common.v.

馃[deprecated] Generated by Copilot at 1dc786e

  • Add a scan_module_identifier function to parse a module identifier from a string and return a struct with the name, version, and source (link, F0

@spytheman spytheman merged commit 9e9a084 into vlang:master Nov 19, 2023
43 checks passed
@ttytm ttytm deleted the tools/vpm/scanning-feedback branch December 15, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants