Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: fix generic structs with multiple levels of generic embedding #20042

Merged
merged 1 commit into from
Nov 30, 2023
Merged

ast: fix generic structs with multiple levels of generic embedding #20042

merged 1 commit into from
Nov 30, 2023

Conversation

shove70
Copy link
Contributor

@shove70 shove70 commented Nov 30, 2023

  1. PR ast: fix generics with embed generics structs(fix #20021) #20022 misses the multi-level embedding :(
  2. Add tests.

@spytheman
Copy link
Member

The CI failure is not related.

spytheman
spytheman approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit c19b13e into vlang:master Nov 30, 2023
53 of 54 checks passed
@shove70 shove70 deleted the generics-1 branch November 30, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

@larpon larpon larpon approved these changes

@felipensp felipensp felipensp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shove70 @spytheman @larpon @felipensp