tools.vpm: add manifest fetch for hg repositories, add test #20107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
commented
Dec 6, 2023
| @@ -106,6 +106,9 @@ fn get_mod_vpm_info(name string) !ModuleVpmInfo { | |||
| fn get_ident_from_url(raw_url string) !(string, string) { | |||
| url := urllib.parse(raw_url) or { return error('failed to parse module URL `${raw_url}`.') } | |||
| publisher, mut name := url.path.trim_left('/').rsplit_once('/') or { | |||
| if settings.vcs == .hg && raw_url.count(':') > 1 { | |||
| return '', 'test_module' | |||
There was a problem hiding this comment.
Anything would be fine here. This just makes sure a name is returned when a localhost address is fetched during tests that doesn't contain a path after the domain. The eventual module name is derived from the manifest.
ttytm
force-pushed
the
tools/vpm/fetch-hg-manifest
branch
from
27e71e2
to
28d5474
Compare
spytheman
reviewed
Dec 7, 2023
| @@ -166,15 +167,14 @@ fn test_install_potentially_conflicting() { | |||
|
|
|||
| fn test_get_installed_version() { | |||
| test_project_path := os.join_path(test_path, 'test_project') | |||
| os.mkdir_all(test_project_path)! | |||
| mut res := os.execute('git init ${test_project_path}') | |||
There was a problem hiding this comment.
Very nice ... I did not know, that git init folder will create it.
spytheman
reviewed
Dec 7, 2023
| import net | ||
| import time | ||
|
|
||
| fn hg_serve(hg_path string, path string) (&os.Process, int) { |
There was a problem hiding this comment.
Hm, this should have needed pub. I am not sure, why it did not fail to compile... Perhaps because it is used in a test file?
spytheman
reviewed
Dec 7, 2023
| import time | ||
|
|
||
| fn hg_serve(hg_path string, path string) (&os.Process, int) { | ||
| mut port := 8000 |
There was a problem hiding this comment.
Start probing from some more obscure port. 8000 and 8080 are very likely to be taken by other tests, between the time you check, and the time the mercurial server starts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR resolves a todo by fetching and checking the manifest for mercurial repos before installation and adds a first test for projects using mercurial.
mercurial only needs installation on mac runners. It's a default for Ubuntu and Windows runners: https://github.com/actions/runner-images
馃[deprecated] Generated by Copilot at 27e71e2
Improved the
vpmtool's support for installing V modules from Mercurial repositories. Added tests, refactored code, and fixed parsing errors for Mercurial URLs. Modified the macOS CI workflow to installmercurialas a dependency. Added atest_utilsmodule with a helper function for running a local Mercurial server.馃[deprecated] Generated by Copilot at 27e71e2
parse.v(link)get_manifest_from_respfunction inparse.v(link)test_utils/utils.v(link)git initcommand ininstall_test.v(link)v.modfile fails ininstall_test.v,install_version_input_test.v, andinstall_version_test.v(link, link, link)mercurialas a dependency for macOS CI tests in.github/workflows/macos_ci.yml(link)