-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checker: handle casted type matches #20111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta456
commented
Dec 6, 2023
Delta456
commented
Dec 6, 2023
JalonSolov
reviewed
Dec 10, 2023
spytheman
reviewed
Dec 10, 2023
…ath { sin, cos }`" This reverts commit ddf0468.
Delta456
force-pushed
the
match_branch_check_casts
branch
from
December 13, 2023 17:50
1def493
to
d78c552
Compare
spytheman
reviewed
Dec 14, 2023
spytheman
reviewed
Dec 14, 2023
spytheman
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19248
🤖[deprecated] Generated by Copilot at cce27af
This pull request adds type checking and casting logic for match expressions in the
vlib/v/checker
module. It also adds several test files in thevlib/v/checker/tests
directory to verify the correct behavior and error messages for different cases of match expressions with type casts.🤖[deprecated] Generated by Copilot at cce27af
explicit_cast_type
andneed_explicit_cast
to store the expected type and the flag for explicit type casting in match branches (link)explicit_cast_type
to the type of the first branch and check if it is a cast expression (link)explicit_cast_type
andneed_explicit_cast
and report errors if they are not consistent (link)match_incorrect_cast_branch_err.vv
andmatch_incorrect_cast_branch_err.out
) (link, link)match_last_branch_only_casted.vv
andmatch_last_branch_only_casted.out
) (link, link)match_no_branch_cast_rest_casted_err.vv
andmatch_no_branch_cast_rest_casted_err.out
) (link, link)