Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools.shader: simplify, remove redundancies #20161

Merged
merged 2 commits into from Dec 13, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Dec 12, 2023

related to: #20156 (comment)

Viewing the changes split into the two commits, makes it hopefully easier two spot the unnecessary compilation and redundancy.

馃[deprecated] Generated by Copilot at 3b79958

Refactored vshader.v to streamline sokol shader compilation. Removed unnecessary code and made it platform-independent.

馃[deprecated] Generated by Copilot at 3b79958

  • Rename shdc variable to shdc_exe for clarity and consistency (link, link, link)
  • Remove redundant shdc_exe function and inline its body (link, link)
  • Replace file variable with shdc_exe and simplify os.mv logic (link, link)

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit 17bf8d1 into vlang:master Dec 13, 2023
43 checks passed
@ttytm ttytm deleted the tools.shader/simplify branch December 15, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants