Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: make os.cache_dir() and os.vtmp_dir() more robust to parallel test executions, extract common code #20495

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

spytheman
Copy link
Member

@spytheman spytheman commented Jan 11, 2024

Intended to fix failures similar to this one:
https://github.com/vlang/v/actions/runs/7487373820/job/20387668781

 FAIL  [ 153/1701]  2033.642 ms vlib/flag/usage_example_test.v
V panic: mkdir failed for "C:\Users\runneradmin\.cache", because CreateDirectory 
returned: Cannot create a file when that file already exists.

@JalonSolov
Copy link
Contributor

Seems like an odd error message, to see "cannot create a file" when you called CreateDirectory. Is that coming from Windows?

@spytheman
Copy link
Member Author

Seems like an odd error message, to see "cannot create a file" when you called CreateDirectory. Is that coming from Windows?

Yes, it is weird, and yes, it is from Windows (a msvc job).

@spytheman spytheman merged commit b120c10 into vlang:master Jan 12, 2024
48 checks passed
@spytheman spytheman deleted the os_improve_cache_dir_and_vtmp_dir branch January 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants