Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checker: cleanup the const variable evaluate for fixed array fields of structs #20503

Merged
merged 1 commit into from Jan 12, 2024
Merged

checker: cleanup the const variable evaluate for fixed array fields of structs #20503

merged 1 commit into from Jan 12, 2024

Conversation

shove70
Copy link
Contributor

@shove70 shove70 commented Jan 12, 2024

This PR:

  • The fixed array size evaluation logic for the struct fields did not take into account the multidimensional case, so the code has been cleaned up and adjusted to be consistent with the fixed array size evaluation logic in the containers.v.
  • fn array_fixed_has_unresolved_size() is added to avoid unwanted evaluation.
  • The related test cases were modified.

spytheman
spytheman approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 🚀 🥳 ❣️

@spytheman spytheman merged commit cfd8915 into vlang:master Jan 12, 2024
54 checks passed
@shove70 shove70 deleted the fixed_array_fields_eval branch January 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shove70 @spytheman