Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.json2: improve error message upon missing comma #20602

Merged
merged 2 commits into from Mar 12, 2024
Merged

x.json2: improve error message upon missing comma #20602

merged 2 commits into from Mar 12, 2024

Conversation

pierrec
Copy link
Contributor

@pierrec pierrec commented Jan 20, 2024

Fixes #6932.

spytheman
spytheman requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but please also add a small test, that checks the error (with assert err.msg().contains('invalid token') for example.

@pierrec @spytheman
x.json2: improve error message upon missing comma
b941e94 
Fixes vlang#6932.

Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
@pierrec @spytheman
x.json2: add test for missing comma error message
67f5ec5 
Signed-off-by: Pierre Curto <pierre.curto@gmail.com>
@spytheman
Copy link
Member

(rebased over current master)

spytheman
spytheman approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit aeadc0a into vlang:master Mar 12, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

json parser not reporting syntax errors
2 participants
@pierrec @spytheman