jsgen: Fix u16 Handling in JavaScript Backend [20618#issuecomment-1902617931] #20620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGRei
force-pushed
the
fix_javascript_backend_treats_u32_as_i32
branch
from
b7595b0
to
7685411
Compare
Yes, adding some more assertions will be nice, so that potential regressions can be detected earlier. |
|
It's done |
spytheman
force-pushed
the
fix_javascript_backend_treats_u32_as_i32
branch
from
5d3d498
to
9d21f21
Compare
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Jan 29, 2024
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed this reported issue : #20618 (comment)
@spytheman Do you need test file?
Thanks.