Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: enable @[export] for global #20649

Merged
merged 2 commits into from
Jan 25, 2024
Merged

v: enable @[export] for global #20649

merged 2 commits into from
Jan 25, 2024

Conversation

felipensp
Copy link
Member

Fix #20477

const foo = "bar"

@[export]
__global global_exported = foo + "qux"
0000000000000000       O *UND*  0000000000000000              global_exported

spytheman
spytheman approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@felipensp felipensp marked this pull request as ready for review January 25, 2024 13:39
@spytheman spytheman merged commit e1655ff into vlang:master Jan 25, 2024
54 checks passed
@odiroot
Copy link

odiroot commented Jan 25, 2024

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Globals symbols are dropped (not exported) when -skip-unused is applied
3 participants
@felipensp @odiroot @spytheman