dtm: Optimization of parser/gen of template #20751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JalonSolov
reviewed
Feb 7, 2024
spytheman
reviewed
Feb 8, 2024
GGRei
force-pushed
the
improve_dtm_generation
branch
from
7929b66
to
c537d28
Compare
|
Ok, I've reverted back by one commit. Do you think instead I should mention in the documentation that not using the minifier when the cache is disabled can improve performance, especially for smaller templates? |
|
Yes, that is good information to document. Then the user can decide for themselves what is suitable. |
GGRei
force-pushed
the
improve_dtm_generation
branch
from
1962617
to
86b43b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template parsing and rendering system has been completely overhauled for significant performance improvements.