Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix init_global_test.v failing occasionally #20879

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

smalltalkman
Copy link
Contributor

No description provided.

Signed-off-by: Yuanmiao Gui <gui_yuan_miao@163.com>
@smalltalkman smalltalkman marked this pull request as draft February 20, 2024 09:28
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman
Copy link
Member

I am not sure if that was the only reason to mark the test as flaky in 5277ce7 2022-04-30 ... We can perhaps remove // vtest flaky: true line at the top, and see if it will fail again in the near future on the CI.

@smalltalkman
Copy link
Contributor Author

I am not sure if that was the only reason to mark the test as flaky in 5277ce7 2022-04-30 ...

I'm only encountering this error in my current testing and can't determine if this error is the sole cause.

We can perhaps remove // vtest flaky: true line at the top, and see if it will fail again in the near future on the CI.

My current idea is to observe it for a period of time in local testing

In addition, I didn't figure out the real intention of assert n > 0, so I'm worried that this PR destroyed the original author's code logic

@smalltalkman smalltalkman marked this pull request as ready for review February 21, 2024 03:18
@spytheman
Copy link
Member

I think the idea was to check, that it passed through at least one lock/unlock cycle.

@spytheman
Copy link
Member

My current idea is to observe it for a period of time in local testing

ok

@spytheman spytheman merged commit 27e6fef into vlang:master Feb 21, 2024
48 checks passed
@smalltalkman smalltalkman deleted the fix-init_global_test branch February 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants