checker: fix some specific interface generic inference within generic struct and method #20932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s struct and method
|
Does it work for #20762 too? |
From what I've seen, no, this does not resolve the issue 20762. For this other problem, the compiler fails to make the connection and deduce that it is an interface:
The compiler marks it as a placeholder, and that's what causes the problem. When the "unwrap_generic" method is used, everything apparently goes correctly since for both methods (the generic and the one with a specified concrete type), it results in:
But for one, the interface is recognized, and for the other, it is not. Unfortunately, I have not had the time to investigate further at the moment. |
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Mar 9, 2024
…s struct and method (vlang#20932)
raw-bin
pushed a commit
to raw-bin/v
that referenced
this pull request
Mar 9, 2024
…s struct and method (vlang#20932)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19214