Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: fix module lookup if module import parts end with the word modules #21083

Merged
merged 4 commits into from
Mar 24, 2024
Merged

utils: fix module lookup if module import parts end with the word modules #21083

merged 4 commits into from
Mar 24, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 23, 2024

Fixes #21078

Contains a little module import name correction.

Should we run the related example run in CI and add a info comment to not change the modules name?

@ttytm ttytm changed the title utils: fix module lookup if module import parts contains the word modules utils: fix module lookup if module import parts contain the word modules Mar 23, 2024
@ttytm ttytm changed the title utils: fix module lookup if module import parts contain the word modules utils: fix module lookup if module import parts end with the word modules Mar 23, 2024
@spytheman spytheman mentioned this pull request Mar 24, 2024
Closed
@spytheman
Copy link
Member

spytheman commented Mar 24, 2024 •
edited
Loading

Should we run the related example run in CI and add a info comment to not change the modules name?

Yes, that would be best. v build-examples uses only the absolute paths, and thus worked, while compiling with the relative path was a problem, and it went undetected.

spytheman
spytheman approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit f66b595 into vlang:master Mar 24, 2024
53 of 54 checks passed
@ttytm ttytm deleted the utils/fix-module-lookup branch March 25, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot compile examples/submodule
2 participants
@ttytm @spytheman