Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: use fixed size array for max_len const #21140

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 29, 2024

Makes minor code vetting / optimization in fmt/fmt.v. An array with a max len for a const named max_len.

vlib/v/fmt/struct.v Outdated Show resolved Hide resolved
vlib/v/fmt/fmt.v Outdated Show resolved Hide resolved
@spytheman spytheman marked this pull request as draft March 29, 2024 17:25
@ttytm ttytm marked this pull request as ready for review March 29, 2024 19:27
@ttytm ttytm force-pushed the fmt/max-len-arr-for-max-len branch from 0f22cac to 948985d Compare March 29, 2024 19:28
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, the new const names are much clearer.

@spytheman spytheman merged commit aea1471 into vlang:master Mar 30, 2024
42 checks passed
@ttytm ttytm deleted the fmt/max-len-arr-for-max-len branch March 30, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants