Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vet: allow to overwrite excluded dirs #21142

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 29, 2024

Allows to run vet over paths that include e.g. tests or testdata when explictly passing them. Currently, they will be excluded without any information.

# Current
v vet vlib/v/fmt/testdata # Silently skipped

# With changes
v vet vlib/v/fmt/testdata # Vetted when explicitly specified
v vet vlib/v/fmt # Subdir /testdata will skipped

This feature also removes the need for keeping a flag that was used for vet development / test purposes.

E.g. checking out the first commit that just removes the flag before extending the functionality and running below will show the problems solved.

v cmd/tools/vvet/vet_test.v

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit a4ff389 into vlang:master Mar 30, 2024
42 checks passed
@ttytm ttytm deleted the vet/overwrite-exclude branch March 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants