fmt: don't change paths when formatting imports #21148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To further improve test coverage and to better prevent regressions, I would add formatting check over an official extensive project like v-analyzer to Vs regular CI. |
|
CI step added isolated on a separate branch - to verify it would recognize formatting issues https://github.com/ttytm/v/actions/runs/8489249682/job/23259136533 |
spytheman
reviewed
Mar 30, 2024
| v fmt -c . | ||
| exit_code=$? | ||
| if [[ $exit_code -ne 0 && $exit_code -ne 5 ]]; then | ||
| # Don't fail on on internal errors |
There was a problem hiding this comment.
Suggested change
| # Don't fail on on internal errors | |
| # Don't fail on internal errors |
spytheman
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spytheman your point made here #21134 (comment) confirms itself.
With our current module lookup there are more scenarios where it is required to keep the a
src.part in the import. E.g. in v-analyzer forbuild.vsh(src.metadata) or intools/project-checker.v. By removing thesrc.prefix vfmt would break the functionality, since the imported modules are not found anymore.Now vfmt would not try to "outsmart" anymore. And for scenarios where an import prefixed with
src.and as well as the path withoutsrc.are valid, both will be also seen as valid by vfmt.General formatting will still happen ofc, unused import symbols will be cleared, just the path of the import won't be changed anymore.
The tests that check for the import path update were removed. All other behavior is tested due to older and recently added tests, the changes should be covered.