-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toml: update the alexcrichton and BurntSushi repos to their successors toml-rs, and toml-test, record new exceptions #21152
toml: update the alexcrichton and BurntSushi repos to their successors toml-rs, and toml-test, record new exceptions #21152
Conversation
…ithub.com/toml-lang/toml-test.git, record new exceptions
@larpon, sorry for the noise. I realized too late, that the successor repo for alexcrichton, can be used directly, since it also contains the commit 499e8c4, which we need. I think the PR should be stable enough for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @spytheman thanks for taking care of this. The changes look fine to me - the CI job definitely looks a lot nicer now. Did you have a specific reason to not rename burntsushi/alexcrihton, if those tests are now the official tests?
I only have one issue locally:
All separate tests (alexcrichton_toml_rs_test.v
, burntsushi_toml_test.v
iarna_toml_spec_test.v
and large_toml_file_test.v
) pass on my system (EndeavourOS Arch/rolling) when run separately, but running:
VTEST_TOML_DO_YAML_CONVERSION=1 VTEST_TOML_DO_LARGE_FILES=1 ./v test vlib/toml
Note the e
vs. E
I'm not sure if that is because I'm on newer versions of the software stack or what 🤔
I remember we had to do some shoehorning / tweaking of some test data/results because of the YAML conversions I'm not sure if this might be one of those 🤔
v/vlib/toml/tests/iarna_toml_spec_test.v Lines 343 to 381 in 59a5a79
So it might be a tool update that might have fixed/changed the scientific notation. Also seems we've closed the |
I could not get the problem to show up locally @larpon , and it seems it is also passing on the CI. I suspect that the used Edit: on the CI, it is also |
Just minimization of the commit diff. I did not want to have both renames and code changes in the same PR. |
Fix #20933 .