-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x.json2,checker,toml: allow field.typ compile-time checking with MatchExpr and add array of option checking #21171
Merged
spytheman
merged 4 commits into
vlang:master
from
felipensp:match_comptime_type_checking
Apr 4, 2024
Merged
x.json2,checker,toml: allow field.typ compile-time checking with MatchExpr and add array of option checking #21171
spytheman
merged 4 commits into
vlang:master
from
felipensp:match_comptime_type_checking
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome! The same can be applied to toml then! |
ttytm
reviewed
Apr 2, 2024
what about maps? |
JalonSolov
reviewed
Apr 2, 2024
It does works. struct Test {
a int
b []int
c map[int]string
}
fn main() {
$for f in Test.fields {
type_name := typeof(f.$(f.name)).name
match f.typ {
int { println('1. ${f.name} is ${type_name}') }
[]int { println('2. ${f.name} is ${type_name}') }
map[int]string { println('3. ${f.name} is ${type_name}') }
else {}
}
}
} |
Is there a way to check the key and the value type of a map separately? |
No yet. This would be an another feature request. |
spytheman
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21170
Improve type checking from #21163