Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml: update entity parse test #21190

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 5, 2024

Upgrades an xml test that assigns values to the private field parsed_reverse_entities which in an external test. Otherwise, the fields data is only used internally.

struct Prolog {
parsed_reverse_entities map[string]string = default_entities_reverse.clone()
pub:

The new test might be more robust and easier to follow as well, as it compares the parses files with entities with an an expected file that have the entities already resolved.

The upgrade is also required for #21183

ttytm added a commit to ttytm/v that referenced this pull request Apr 5, 2024
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit a7d68cb into vlang:master Apr 5, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants