v.util: improve find_diff_cmd: don't add spaces to result without env opts #21242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Apr 10, 2024
spytheman
reviewed
Apr 10, 2024
|
Let's please prefer #21247 over this one since conflicts due to test extension will have to be resolved in one of them. It should cover potential mac CI failure after a merge as well. |
|
#21247 is merged now. |
ttytm
force-pushed
the
util/add-test-improve-find-working-diff
branch
from
32ddb7f
to
a4583f8
Compare
ttytm
changed the title
ttytm
force-pushed
the
util/add-test-improve-find-working-diff
branch
from
a4583f8
to
74486d3
Compare
spytheman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for the diff util module.
Fixes an issue where
find_working_diff_command()!adds spaces to the result, potentially making it unavailable to other commands. E.g.os.find_abs_path_of_executablewould not find the result of the function.Might even be required to make the changes in #21243 robust.