Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdoc: cleanup node.v #21250

Merged
merged 1 commit into from Apr 11, 2024
Merged

vdoc: cleanup node.v #21250

merged 1 commit into from Apr 11, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 11, 2024

Pushing the fix for the vdoc sorting issue on non linux after this one to enable tests there as well.

Comment on lines -51 to +48
mut contents := cnts.keys().map(cnts[it])
mut contents := cnts.values()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rg '\.keys\(\).map\(' returned a few more potential candidates:

#0 18:56:57 ᛋ master /v/oo❱rg '\.keys\(\).map\('
vlib/net/http/header.v:504:new_keys := arrays.distinct(h.keys().map(it.to_lower()))
vlib/v/doc/node.v:51:mut contents := cnts.keys().map(cnts[it])
vlib/v/tests/map_literals_method_call_test.v:4:}.keys().map({
vlib/v/tests/bench/math_big_gcd/prime/maker.v:176:return tmp.keys().map(tmp[it])
cmd/tools/vdoc/vdoc.v:64:jw.write_string(json.encode(d.contents.keys().map(d.contents[it])))
#0 16:21:05 ᛋ master /v/oo❱

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 6dc417e into vlang:master Apr 11, 2024
44 checks passed
@ttytm ttytm deleted the vdoc/cleanup-node branch April 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants