checker: allow pass array as mut param to spawn fn #21283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only problem with making this work, is that it makes V less safe. If multiple threads start modifying arrays at the same time, it could wreak all sorts of havok... the least being that it can cause very hard to debug issues, since they won't hit unless multiple threads beat on the array at the same time. |
|
But this seem to already work with structs so a choice is to be made |
|
@medvednikov what do you think? |
|
it does work for structs, so i think it should be allowed we need to implement a way to catch such bugs (ownership? lol) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21280