Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: update command_test.v #21307

Merged
merged 2 commits into from
Apr 18, 2024
Merged

cli: update command_test.v #21307

merged 2 commits into from
Apr 18, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 18, 2024

No description provided.

spytheman
spytheman reviewed Apr 18, 2024
View reviewed changes
vlib/cli/command_test.v Outdated Show resolved Hide resolved
@ttytm @spytheman
apply suggestions
421c30f 
Co-authored-by: Delyan Angelov <26967+spytheman@users.noreply.github.com>
spytheman
spytheman approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Deleting code, while keeping the functionality, and improving the readability 🥳.

@spytheman spytheman merged commit bccf660 into vlang:master Apr 18, 2024
43 of 44 checks passed
@ttytm ttytm deleted the cli/update-command-test branch April 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttytm @spytheman