-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update test-self
to allow to choose running tests for cmd and vlib
#21326
Conversation
2e3b26a
to
490ac08
Compare
… cmd prefixes" This reverts commit 490ac08.
What do you think of modifying Then It will be also a bit more flexible, since in some cases, you may want to do: |
Awesome idea. Thank you for the input! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work 🥳 🚀 !
With the changes, it will be possible to choose to run
v test-self
for project parts incmd
andvlib
. By default - as it already is - both will be included, the same when passing both flagsv test-self --vlib --cmd
.This can also help with local development but is mainly motivated to further improve our current CI - running parts when and where required.
As far as I can see, when changes are made just to a cmd tool, it should usually not require to run tests for the whole vlib. While changes to the vlib should include running tests for cmd tools. On the CI part, this can skyrocket tool development and reduce stress on vlib development. As PRs including updates just made to a tool without changes on the vlib can skip the most heavy part of CI.
Workflow update suggestions would happen in a follow-up.