ci: simplify workflow conditions #21338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the workflow condition that ensures that workflows run on all branches on forks, initially added here #14498
The PR simplifies the conditions by accessing the required values directly instead of retrieving them from a further nested event object.
I double-checked the correctness of the values with the docs and by reviewing their values on a fork. Still, please don't hesitate to share any potential concerns so they can be addressed. The change is part of a more exciting evolution that I'm preparing for a follow-up that will help improve developer convenience, but this one could be a nice to have in the history separately.