Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update detection of workflow cancellation scenarios #21342

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 24, 2024

The change should improve and extend our current concurrency and cancellation management. In doing this, it should also allow for simplifications.

The main change is about using concurrency groups that are more tailored to relevant scenarios:

  • It will make adding conditions to every job obsolete, which are currently required to control workflow runs for forks and to prevent CI pollution on the original repository.
  • It will make it more pleasant to work on branches on forks before opening PRs. Currently, pushing changes to the same branch on a fork will not cancel running and waiting workflows, unlike in a PR. Therefore, it's easy to run into blocked CI that would require long waiting times or manual cancellation to free the CI pipeline. Now, making the cancellation policy on a fork branch the same as for a PR should be the most helpful CI behavior.
    (for more rare cases where it is useful to not cancel running CI but to stack the CI pipeline on a fork, it is still possible to push the master or another branch)

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@medvednikov medvednikov merged commit 28cabf4 into vlang:master Apr 24, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants