Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add check for result type on chan init #21363

Merged
merged 2 commits into from
May 2, 2024
Merged

parser: add check for result type on chan init #21363

merged 2 commits into from
May 2, 2024

Conversation

felipensp
Copy link
Member

Fix #21337

spytheman
spytheman reviewed Apr 28, 2024
View reviewed changes
vlib/v/parser/parser.v Outdated Show resolved Hide resolved
@felipensp felipensp changed the title parser: add check for result or option type on chan init parser: add check for result type on chan init May 1, 2024
@felipensp felipensp marked this pull request as ready for review May 1, 2024 12:49
spytheman
spytheman approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 7c89d77 into vlang:master May 2, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delta456 Delta456 Delta456 left review comments

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"c := chan !string{}" -> error: unexpected token !, expecting {
3 participants
@felipensp @spytheman @Delta456