Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update symlink ci, add matrix #21376

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 29, 2024

Makes use of a matrix for jobs that share the same steps cross-platform or have marginal differences. This allows for easier and more consistent changes, and should simplify maintainability by reducing redundancy and eliminating the need to update and review the same things in multiple places.

Notable changes:

  • While the changes manage to mainly simplify things, they also include an extension in functionality: testing sudo symlinking on macOS.
  • Summary messages were removed. Although they are a nice gimmick, they have no real technical benefit. But please don't hesitate to let me know if summary messages should be preserved.

The changes are part of finalizing on planed rougher-/maintenance-changes to the CI, before moving towards suggestions that are more enhancement-based.

@spytheman
Copy link
Member

Summary messages were removed. Although they are a nice gimmick, they have no real technical benefit. But please don't hesitate to let me know if summary messages should be preserved.

I agree. I hoped, that they would show in other places (like the gh command line monitoring system) but currently they do not offer advantages in that regard.

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 284aa9d into vlang:master Apr 29, 2024
10 checks passed
@ttytm ttytm deleted the ci/symlink-matrix branch April 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants