builder: simplify generic cc detection #21380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Apr 29, 2024
vlib/v/builder/cc.v
Outdated
| eprintln('Compilation with unknown C compiler') | ||
| ccoptions.cc = .unknown | ||
| } | ||
| cc_ver := os.execute_opt('cc --version') or { panic('unknown C compiler') } |
There was a problem hiding this comment.
do not use panics here please
There was a problem hiding this comment.
Without that panic, if I do not have cc:
With that panic:
I really do prefer the first message.
There was a problem hiding this comment.
K gonna update, currently it is merely a refactor. Pulling the panic from the else block into the or block with no error messages changed.
ttytm
force-pushed
the
builder/simplify-cc-detect
branch
2 times, most recently
from
f6a11c0
to
96328b0
Compare
ttytm
force-pushed
the
builder/simplify-cc-detect
branch
from
96328b0
to
8ee55e4
Compare
spytheman
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces nesting / loc by handling a potential fatal error directly.