ci: update detection of accidentally added gpl licenses #21384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttytm
force-pushed
the
ci/gpl-detect
branch
3 times, most recently
from
5c9a5c0
to
14e7645
Compare
spytheman
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates poor detection in the job that tries to prevent GPL licensed code.
Currently it is checked for the pattern
"a GPL license". Which will miss to detect a lot of potentially unwanted additions.A GPL license can be GPL-2.0 GPLv2, AGPL, LGPL, LGPLv3, (LGPLv3) etc.. Grepping the projects code-base will give an idea.
A screenshot of a sample run that includes a potential gpl license text:
https://github.com/ttytm/v/actions/runs/8886970660/job/24401414482
If the CI should be triggered and there are no concerns, merging with the failed job should make it green for the run after the merge.