pref: update os_from_string, add missing qnx, remove deprecated wasm options that used - instead of _
#21390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asm options that used `-` instead of `_`
|
Yes, you can remove the messages for |
|
I think current policy is to allow removal 6 months after the deprecation date. Should be more than enough time for someone to update their code, if they're paying any attention to it at all. |
spytheman
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would extract a functional change from other updates I'd like to suggest.
As a change that is quasi related to the scope of the update - can the deprecated options be removed here? I've seen removing deprecated code is on the list, and these have been deprecated for quite some time.