-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pass a good commit to oldv.v in bootstrapping_ci.yml
#21393
Conversation
2cf6abe
to
2a29a4d
Compare
f270b49
to
662ba86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work.
Looks like additional verification if a sha is still present on master is needed. In case of force pushes or why ever they are not available anymore? What do you think @spytheman? Edit: Oh okay, re-running can work too. Looks rather like it was a wrong api response. Failed run for reference: |
The changes should be able to address: fd66067#commitcomment-141513977
A small change included here is a resolved linter complaint for the empty
B_CFLAGS: ''
Would address it, but as the var is apparently not used it was removed.