Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pass a good commit to oldv.v in bootstrapping_ci.yml #21393

Merged
merged 5 commits into from
May 1, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 30, 2024

The changes should be able to address: fd66067#commitcomment-141513977

A small change included here is a resolved linter complaint for the empty

B_CFLAGS:

B_CFLAGS: '' Would address it, but as the var is apparently not used it was removed.

@ttytm ttytm marked this pull request as draft April 30, 2024 23:34
@ttytm ttytm marked this pull request as ready for review April 30, 2024 23:42
@ttytm ttytm force-pushed the ci/update-bootstrapping branch 2 times, most recently from f270b49 to 662ba86 Compare May 1, 2024 02:21
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 3ec1994 into vlang:master May 1, 2024
7 checks passed
@ttytm ttytm deleted the ci/update-bootstrapping branch May 1, 2024 12:12
@ttytm
Copy link
Member Author

ttytm commented May 2, 2024

Looks like additional verification if a sha is still present on master is needed. In case of force pushes or why ever they are not available anymore?

What do you think @spytheman?

Edit: Oh okay, re-running can work too. Looks rather like it was a wrong api response. Failed run for reference:
https://github.com/vlang/v/actions/runs/8919311144/attempts/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants